Skip to content

Ghostscript 10.05.0 update#14

Merged
jwaisner merged 1 commit into
mainfrom
10.05
Apr 27, 2025
Merged

Ghostscript 10.05.0 update#14
jwaisner merged 1 commit into
mainfrom
10.05

Conversation

@N6REJ
Copy link
Copy Markdown
Contributor

@N6REJ N6REJ commented Apr 27, 2025 •
edited by qodo-code-review Bot
Loading

PR Type

enhancement, configuration changes

Description

  • Add support for Ghostscript 10.05.0 release.

    • Introduce new configuration and update release properties.
    • Add batch script for CIDFMAP update with new version.

  • Update bundle release date to 2025.4.26.

Changes walkthrough 📝

Relevant files
Enhancement
update_cidfmap.bat
Add batch script for CIDFMAP update in 10.05.0                     

bin/ghostscript10.05.0/update_cidfmap.bat

  • Add new batch script for updating CIDFMAP.
  • Script uses gswin64c.exe and sets font/CIDFMAP paths.
    		• +4/-0     
    Configuration changes
    bearsampp.conf
    Add configuration for Ghostscript 10.05.0                               

    bin/ghostscript10.05.0/bearsampp.conf

  • Add configuration file for Ghostscript 10.05.0.
  • Define executable paths and bundle release placeholder.
    		• +5/-0     
    build.properties
    Update bundle release date in build properties                     

    build.properties

    • Update bundle release date to 2025.4.26.
    		 +1/-1     
    releases.properties
    Add Ghostscript 10.05.0 to releases properties                     

    releases.properties

    • Add release entry for Ghostscript 10.05.0 with new download URL.
    		 +1/-0     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @N6REJ N6REJ added the enhancement ✨ Improve program label Apr 27, 2025
    @qodo-code-review
    Copy link
    Copy Markdown

    qodo-code-review Bot commented Apr 27, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-code-review
    Copy link
    Copy Markdown

    qodo-code-review Bot commented Apr 27, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Use relative paths consistently

    Use relative paths with %~dp0 prefix for the lib directory to ensure the script
    works correctly regardless of the current working directory.

    bin/ghostscript10.05.0/update_cidfmap.bat [4]

    -bin\gswin64c.exe -q -dBATCH -sFONTDIR=c:/windows/fonts -sCIDFMAP=lib/cidfmap lib/mkcidfm.ps
+bin\gswin64c.exe -q -dBATCH -sFONTDIR=c:/windows/fonts -sCIDFMAP=%~dp0lib/cidfmap %~dp0lib/mkcidfm.ps
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    __

    Why: The suggestion correctly identifies a potential issue where the script uses relative paths for lib files without the %~dp0 prefix, which could cause failures if the current directory changes. Adding %~dp0 to the lib paths ensures the script will work correctly regardless of where it's executed from.

    		Medium
    • More

    @jwaisner jwaisner merged commit f7a282a into main Apr 27, 2025
    @jwaisner jwaisner deleted the 10.05 branch April 27, 2025 19:43
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    enhancement ✨ Improve program

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @N6REJ @jwaisner